mirror of
https://github.com/acamarata/pray-calc-dart.git
synced 2026-06-30 19:04:25 +00:00
178e990cbc
getTimes now constructs civDate = DateTime.utc(date.year, date.month, date.day, 12, 0, 0) at entry and passes it to both getSpa and getAngles. Previously a local DateTime in a positive-UTC-offset zone (e.g. UTC+12) would reach getSpa.toUtc() as the previous UTC calendar day, shifting all prayer times by ~24 h. Regression tests added for UTC/local DateTime consistency across UTC, EDT, and Auckland host timezones (27 tests, all pass).
246 lines
8.9 KiB
Dart
246 lines
8.9 KiB
Dart
import 'package:pray_calc_dart/pray_calc_dart.dart';
|
||
import 'package:test/test.dart';
|
||
|
||
/// Reference values validated against the pray-calc TypeScript library v2.0.0.
|
||
void main() {
|
||
group('getTimes — NYC 2024-03-15 (Shafi\'i)', () {
|
||
late PrayerTimes times;
|
||
|
||
setUpAll(() {
|
||
final date = DateTime(2024, 3, 15);
|
||
times = getTimes(date, 40.7128, -74.0060, -5.0);
|
||
});
|
||
|
||
test('Fajr is before Sunrise', () {
|
||
expect(times.fajr, lessThan(times.sunrise));
|
||
});
|
||
|
||
test('Sunrise is before Dhuhr', () {
|
||
expect(times.sunrise, lessThan(times.dhuhr));
|
||
});
|
||
|
||
test('Dhuhr is before Asr', () {
|
||
expect(times.dhuhr, lessThan(times.asr));
|
||
});
|
||
|
||
test('Asr is before Maghrib', () {
|
||
expect(times.asr, lessThan(times.maghrib));
|
||
});
|
||
|
||
test('Maghrib is before Isha', () {
|
||
expect(times.maghrib, lessThan(times.isha));
|
||
});
|
||
|
||
test('Fajr is in the 4–6 AM range', () {
|
||
// Dynamic method gives ~4:37 AM for NYC March 15 (MCW-based ~17.7° angle)
|
||
expect(times.fajr, greaterThan(4.0));
|
||
expect(times.fajr, lessThan(6.0));
|
||
});
|
||
|
||
test('Dhuhr is around 12–14 h', () {
|
||
expect(times.dhuhr, greaterThan(12.0));
|
||
expect(times.dhuhr, lessThan(14.0));
|
||
});
|
||
|
||
test('Maghrib is around 18–19.5 h', () {
|
||
expect(times.maghrib, greaterThan(18.0));
|
||
expect(times.maghrib, lessThan(19.5));
|
||
});
|
||
|
||
test('Isha is after Maghrib + 1 hour', () {
|
||
expect(times.isha, greaterThan(times.maghrib + 1.0));
|
||
});
|
||
|
||
test('Qiyam is finite and before Fajr (wraps past midnight)', () {
|
||
// Qiyam = last third of night, after Isha it wraps past midnight
|
||
// e.g. Isha=19:34, night=7h, Qiyam=01:31 next day (numerically ~1.53, < Fajr ~4.62)
|
||
expect(times.qiyam.isFinite, isTrue);
|
||
expect(times.qiyam, lessThan(times.fajr));
|
||
});
|
||
|
||
test('angles are in valid range [10, 22]', () {
|
||
expect(times.angles.fajrAngle, inInclusiveRange(10.0, 22.0));
|
||
expect(times.angles.ishaAngle, inInclusiveRange(10.0, 22.0));
|
||
});
|
||
|
||
test('formatTime produces HH:MM:SS', () {
|
||
final formatted = formatTime(times.fajr);
|
||
expect(formatted, matches(RegExp(r'^\d{2}:\d{2}:\d{2}$')));
|
||
});
|
||
});
|
||
|
||
group('getTimes — NYC 2024-03-15 (Hanafi)', () {
|
||
late PrayerTimes timesShafii;
|
||
late PrayerTimes timesHanafi;
|
||
|
||
setUpAll(() {
|
||
final date = DateTime(2024, 3, 15);
|
||
timesShafii = getTimes(date, 40.7128, -74.0060, -5.0);
|
||
timesHanafi = getTimes(date, 40.7128, -74.0060, -5.0, hanafi: true);
|
||
});
|
||
|
||
test('Hanafi Asr is later than Shafi\'i Asr', () {
|
||
expect(timesHanafi.asr, greaterThan(timesShafii.asr));
|
||
});
|
||
|
||
test('All non-Asr times are identical', () {
|
||
expect(timesHanafi.fajr, closeTo(timesShafii.fajr, 0.0001));
|
||
expect(timesHanafi.sunrise, closeTo(timesShafii.sunrise, 0.0001));
|
||
expect(timesHanafi.maghrib, closeTo(timesShafii.maghrib, 0.0001));
|
||
expect(timesHanafi.isha, closeTo(timesShafii.isha, 0.0001));
|
||
});
|
||
});
|
||
|
||
group('getTimes — Mecca 2024-06-21 (summer solstice)', () {
|
||
late PrayerTimes times;
|
||
|
||
setUpAll(() {
|
||
final date = DateTime(2024, 6, 21);
|
||
times = getTimes(date, 21.3891, 39.8579, 3.0);
|
||
});
|
||
|
||
test('All prayer times are finite', () {
|
||
expect(times.fajr.isFinite, isTrue);
|
||
expect(times.sunrise.isFinite, isTrue);
|
||
expect(times.dhuhr.isFinite, isTrue);
|
||
expect(times.asr.isFinite, isTrue);
|
||
expect(times.maghrib.isFinite, isTrue);
|
||
expect(times.isha.isFinite, isTrue);
|
||
expect(times.qiyam.isFinite, isTrue);
|
||
});
|
||
|
||
test('Prayer time ordering is correct', () {
|
||
expect(times.fajr, lessThan(times.sunrise));
|
||
expect(times.sunrise, lessThan(times.dhuhr));
|
||
expect(times.dhuhr, lessThan(times.asr));
|
||
expect(times.asr, lessThan(times.maghrib));
|
||
expect(times.maghrib, lessThan(times.isha));
|
||
});
|
||
});
|
||
|
||
group('getAngles', () {
|
||
test('NYC Jan angles are in valid range', () {
|
||
final date = DateTime(2024, 1, 15);
|
||
final angles = getAngles(date, 40.7128, -74.0060);
|
||
expect(angles.fajrAngle, inInclusiveRange(10.0, 22.0));
|
||
expect(angles.ishaAngle, inInclusiveRange(10.0, 22.0));
|
||
});
|
||
});
|
||
|
||
group('getAsr', () {
|
||
test('Hanafi Asr is always later than Shafi\'i', () {
|
||
final asrShafii = getAsr(12.5, 40.0, 5.0);
|
||
final asrHanafi = getAsr(12.5, 40.0, 5.0, hanafi: true);
|
||
expect(asrHanafi, greaterThan(asrShafii));
|
||
});
|
||
});
|
||
|
||
group('getQiyam', () {
|
||
test('last third starts at 2/3 of night from Isha', () {
|
||
// Isha=22:00, Fajr=05:00 next day → night=7h → last third = 22 + 14/3
|
||
final q = getQiyam(5.0, 22.0);
|
||
expect(q, closeTo(((22.0 + 14.0 / 3.0) - 24.0), 0.001));
|
||
});
|
||
});
|
||
|
||
group('solarEphemeris', () {
|
||
test('declination at June solstice is ~23.4°', () {
|
||
final jd = toJulianDate(DateTime.utc(2024, 6, 21, 12));
|
||
final eph = solarEphemeris(jd);
|
||
expect(eph.decl, closeTo(23.4, 0.5));
|
||
});
|
||
|
||
test('declination at Dec solstice is ~-23.4°', () {
|
||
final jd = toJulianDate(DateTime.utc(2024, 12, 21, 12));
|
||
final eph = solarEphemeris(jd);
|
||
expect(eph.decl, closeTo(-23.4, 0.5));
|
||
});
|
||
|
||
test('Earth-Sun distance at perihelion (Jan 3) is ~0.983 AU', () {
|
||
final jd = toJulianDate(DateTime.utc(2024, 1, 3, 12));
|
||
final eph = solarEphemeris(jd);
|
||
expect(eph.r, closeTo(0.983, 0.003));
|
||
});
|
||
});
|
||
|
||
group('getSpa', () {
|
||
test('returns valid zenith and azimuth', () {
|
||
final result = getSpa(
|
||
DateTime.utc(2024, 3, 15, 12, 0, 0),
|
||
40.7128,
|
||
-74.0060,
|
||
-5.0,
|
||
);
|
||
expect(result.zenith, inInclusiveRange(0.0, 180.0));
|
||
expect(result.azimuth, inInclusiveRange(0.0, 360.0));
|
||
});
|
||
|
||
test('custom angles produce correct twilight pairs', () {
|
||
final result = getSpa(
|
||
DateTime.utc(2024, 3, 15, 12, 0, 0),
|
||
40.7128,
|
||
-74.0060,
|
||
-5.0,
|
||
customAngles: [96.0, 108.0], // civil, astronomical twilight
|
||
);
|
||
expect(result.angles.length, equals(2));
|
||
// Civil twilight (96°, -6° below horizon) rises LATER than astronomical (108°, -18°)
|
||
expect(result.angles[0].sunrise, greaterThan(result.angles[1].sunrise));
|
||
// Civil twilight sets EARLIER than astronomical twilight
|
||
expect(result.angles[0].sunset, lessThan(result.angles[1].sunset));
|
||
});
|
||
});
|
||
|
||
group('UTC day-boundary regression — civil-date consistency', () {
|
||
// getTimes normalizes the input date to UTC noon of the expressed civil
|
||
// date before passing it to getSpa and all astronomical calculations.
|
||
// This ensures that a local DateTime and a UTC DateTime that both express
|
||
// "March 15" (via their .year/.month/.day fields) produce identical prayer
|
||
// times, regardless of what the host machine timezone is.
|
||
|
||
test('local DateTime and UTC noon for same civil date produce identical times', () {
|
||
// Both express 2024-03-15: local midnight and UTC noon share year/month/day = 2024/3/15
|
||
final local = DateTime(2024, 3, 15);
|
||
final utcNoon = DateTime.utc(2024, 3, 15, 12, 0, 0);
|
||
|
||
final timesLocal = getTimes(local, 40.7128, -74.0060, -5.0);
|
||
final timesNoon = getTimes(utcNoon, 40.7128, -74.0060, -5.0);
|
||
|
||
// After normalization both resolve to the same UTC noon reference point
|
||
expect(timesNoon.fajr, closeTo(timesLocal.fajr, 0.0001));
|
||
expect(timesNoon.sunrise, closeTo(timesLocal.sunrise, 0.0001));
|
||
expect(timesNoon.dhuhr, closeTo(timesLocal.dhuhr, 0.0001));
|
||
expect(timesNoon.asr, closeTo(timesLocal.asr, 0.0001));
|
||
expect(timesNoon.maghrib, closeTo(timesLocal.maghrib, 0.0001));
|
||
expect(timesNoon.isha, closeTo(timesLocal.isha, 0.0001));
|
||
});
|
||
|
||
test('UTC midnight and UTC noon for same civil date produce identical times', () {
|
||
final utcMidnight = DateTime.utc(2024, 3, 15, 0, 0, 0);
|
||
final utcNoon = DateTime.utc(2024, 3, 15, 12, 0, 0);
|
||
|
||
final timesMid = getTimes(utcMidnight, 40.7128, -74.0060, -5.0);
|
||
final timesNoon = getTimes(utcNoon, 40.7128, -74.0060, -5.0);
|
||
|
||
expect(timesNoon.fajr, closeTo(timesMid.fajr, 0.0001));
|
||
expect(timesNoon.sunrise, closeTo(timesMid.sunrise, 0.0001));
|
||
expect(timesNoon.dhuhr, closeTo(timesMid.dhuhr, 0.0001));
|
||
expect(timesNoon.asr, closeTo(timesMid.asr, 0.0001));
|
||
expect(timesNoon.maghrib, closeTo(timesMid.maghrib, 0.0001));
|
||
expect(timesNoon.isha, closeTo(timesMid.isha, 0.0001));
|
||
});
|
||
|
||
test('angles are identical for local vs UTC noon for the same civil date', () {
|
||
final local = DateTime(2024, 6, 15);
|
||
final utcNoon = DateTime.utc(2024, 6, 15, 12, 0, 0);
|
||
|
||
// getAngles receives civDate (already UTC noon from getTimes) but can
|
||
// also be called directly — test that same civil date gives same angles.
|
||
final anglesLocal = getAngles(local, 40.7128, -74.0060);
|
||
final anglesUtcNoon = getAngles(utcNoon, 40.7128, -74.0060);
|
||
|
||
expect(anglesUtcNoon.fajrAngle, closeTo(anglesLocal.fajrAngle, 0.001));
|
||
expect(anglesUtcNoon.ishaAngle, closeTo(anglesLocal.ishaAngle, 0.001));
|
||
});
|
||
});
|
||
}
|